Add --quiet flag that suppresses "waiting for file lock" message
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request and sorry for the late reply! I think the "waiting for file lock" message can be quite useful. Without it, it is not clear why the command hangs. For this reason I would prefer to keep it enabled by default. So I think adding support for the |
Nils-TUD
force-pushed
the
flock-verbose
branch
from
cf9fb03
to
4cacb54
Compare
Nils-TUD
force-pushed
the
flock-verbose
branch
from
4cacb54
to
6dcc9e9
Compare
Nils-TUD
force-pushed
the
flock-verbose
branch
from
6dcc9e9
to
edfc143
Compare
|
No, that was not intended. Not sure what happened there. But I've just pushed the old commit again. |
phil-opp
changed the title
--quiet flag that suppresses "waiting for file lock" message
|
Published as version 0.5.19 |
phil-opp
added a commit
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the "waiting for file lock" message shouldn't be printed unconditionally. In this PR, I've chosen to use the existing verbose flag to turn it on. An alternative would be to use a quiet flag, just as cargo does, to turn it off. I'm not sure what's better.
The reason I ran into this is that I'm using the ninja build system which updates a single line on the console to show the executing commands. That is, only errors create newlines and stay visible. Therefore, I'm passing "-q" to cargo, but unfortunately this get's ignored by cargo-xbuild.
Edit(phil-opp): We decided to add a
--quietflag instead of using the existing--verboseflag.